New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix namespace config #141

Merged

phlptp merged 2 commits into LLNL:master from SimonHeybrock:fix-namespace-config

Mar 10, 2021

Contributor

SimonHeybrock commented Mar 10, 2021

I had two small problems with what was added in #136:

Fix namespace macro when specializing hash.
target_compile_definitions with INTERFACE didn't work, had to change to PUBLIC. I am not sure which is correct and why, but as it is now in master I could not get it to work.

SimonHeybrock added 2 commits

March 10, 2021 12:56


          Use namespace macro

bd9479d


          target_compile_definitions to use PUBLIC

647c14a

Why is INTERFACE not working?

phlptp approved these changes

View reviewed changes

Collaborator

phlptp commented Mar 10, 2021

Thanks, I do need to add a test that builds cmake with a different namespace but not sure it would have caught the hash operations.

phlptp merged commit 63ff891 into LLNL:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet