Unit data operators #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssuming they are power based. +-> * and - to / + and - are only appropriate if the assumption of powers holds true, but it doesn't abstract it very much. * and / are just clearer in my opinion.
…HEADER_ONLY classes are the same as the non-header only classes and the there will be no class conflicts in object files.
Codecov Report
@@ Coverage Diff @@
## master #12 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 3589 3591 +2
=====================================
+ Hits 3589 3591 +2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move <measurement> pow and root to free functions instead of members.
adjust the readme.
move unit root function to free function so the classes are the same under header only and non header only.
adjust the test cases with the new function calls.
add overloads of the units for pow as a free function. I think it still works best to have the units pow function be a member function since it is actually used frequently. root not as much.
unit_base still has a root member since that does a lot of the low level calculations on root powers and wouldn't make sense as a non-member function