Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve to_string for eV and charge units #112

Merged
merged 4 commits into from
Feb 5, 2021

Conversation

SimonHeybrock
Copy link
Contributor

  • eV was formated correctly before, but meV, keV and friends were previously all formated as a 1.60217...e-XY J => format as expected.
  • Ah was previously shown as 3600 C => format as Ah
  • As = C, I suppose this should be kept, despite being slightly inconsistent with the above, since C is so common.
  • Formatting hour as h (as in SI) instead of hr (e.g., kAh instead of kAhr) would be preferrable, but here I kept things consistent with the rest of the library. I suppose formatting options that allow configuring this are a separate discussion.

@codecov-io
Copy link

Codecov Report

Merging #112 (4d65b6b) into master (d40349c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #112   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines         4532      4534    +2     
=========================================
+ Hits          4532      4534    +2     

@phlptp
Copy link
Collaborator

phlptp commented Feb 5, 2021

I think I am going to merge this. Then take a look at tweaking a few things to get rid of some of the specific strings.

I am also going to take another look at making sure the strings are SI compliant including changing the hr to h on the output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants