Improve to_string for eV and charge units #112
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eV
was formated correctly before, butmeV
,keV
and friends were previously all formated as a1.60217...e-XY J
=> format as expected.Ah
was previously shown as3600 C
=> format asAh
As = C
, I suppose this should be kept, despite being slightly inconsistent with the above, sinceC
is so common.hour
ash
(as in SI) instead ofhr
(e.g.,kAh
instead ofkAhr
) would be preferrable, but here I kept things consistent with the rest of the library. I suppose formatting options that allow configuring this are a separate discussion.