Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce MoreInfoScreen and DiscoverScreenViewModel complexity #337

Merged
merged 5 commits into from
Jun 2, 2024
Merged

reduce MoreInfoScreen and DiscoverScreenViewModel complexity #337

merged 5 commits into from
Jun 2, 2024

Conversation

ecornamu
Copy link
Contributor

@ecornamu ecornamu commented Jun 2, 2024 •
edited
Loading

explicit title

@ecornamu ecornamu changed the title reduce MoreInfoScreen complexity still in progress reduce MoreInfoScreen and DiscoverScreenViewModel complexity Jun 2, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 2, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
82.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@JeremyHugentobler JeremyHugentobler self-requested a review June 2, 2024 17:34
JeremyHugentobler
JeremyHugentobler approved these changes Jun 2, 2024
View reviewed changes
Copy link
Contributor

@JeremyHugentobler JeremyHugentobler left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the reformatting ! The code is now easier to read and this will certainly improve the complexity level of those files !!

@ecornamu ecornamu merged commit 99b9b7a into main Jun 2, 2024
3 checks passed
@ecornamu ecornamu deleted the discover/complexity branch June 2, 2024 18:12
@ecornamu ecornamu linked an issue Jun 2, 2024 that may be closed by this pull request
Reduce code complexity of files over 50 #339
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeremyHugentobler JeremyHugentobler JeremyHugentobler approved these changes

Assignees

@ecornamu ecornamu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce code complexity of files over 50
2 participants
@ecornamu @JeremyHugentobler