Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes on the social screens #330

Merged
merged 6 commits into from
May 29, 2024
Merged

Fixes on the social screens #330

merged 6 commits into from
May 29, 2024

Conversation

JeremyHugentobler
Copy link
Contributor

Social screen fixes

Those are the bugs I found:

  • Weird behaviour with already started conversation that were not displayed in the list.
  • Existing conversation, but still empty were shown in the list (not really useful)
  • The share in-app functionnality was not working if you didn't have a previous conversation with the friend

I fixed all of them and I added the fact that when sharing in app, you are redirected to the conversation -> it gives a better feedback that it has been sent

@JeremyHugentobler JeremyHugentobler linked an issue May 29, 2024 that may be closed by this pull request
@JeremyHugentobler JeremyHugentobler self-assigned this May 29, 2024
@JeremyHugentobler JeremyHugentobler added the bug Something isn't working label May 29, 2024
@JeremyHugentobler JeremyHugentobler added this to the Milestone 4 milestone May 29, 2024
Copy link
Contributor

@ecornamu ecornamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job !

@Limandy13 Limandy13 self-requested a review May 29, 2024 16:42
Copy link
Contributor

@Limandy13 Limandy13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me !

Copy link

@JeremyHugentobler JeremyHugentobler merged commit 14c74f7 into main May 29, 2024
3 checks passed
@JeremyHugentobler JeremyHugentobler deleted the fix/social branch May 29, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: Social screens
3 participants