Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Missing remove method for constraint in model part #2897

Merged
merged 1 commit into from
Sep 24, 2018
Merged

[Core] Missing remove method for constraint in model part #2897

merged 1 commit into from
Sep 24, 2018

Conversation

loumalouomega
Copy link
Member

This method was missing in the model part

@loumalouomega loumalouomega added Enhancement FastPR This Pr is simple and / or has been already tested and the revision should be fast Kratos Core labels Sep 18, 2018
@loumalouomega loumalouomega requested a review from a team September 18, 2018 17:08
@adityaghantasala
Copy link
Member

There are other changes which are not related to Constraints. Mostly name changes for formatting. For me they look ok and consistent.
It would be nice if someone from kratos core team can look at those changes and approve also.
Rest with respect to constraint functions, they are consistent and no objects from my side.

RiccardoRossi
RiccardoRossi reviewed Sep 19, 2018
View reviewed changes
Copy link
Member

@RiccardoRossi RiccardoRossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am fine with this commit. @KratosMultiphysics/technical-committee any problem with this?

@loumalouomega loumalouomega requested a review from a team September 21, 2018 07:50
@adityaghantasala
Copy link
Member

@KratosMultiphysics/technical-committee can we go forward with this PR ?

@loumalouomega loumalouomega merged commit e1c54e7 into master Sep 24, 2018
@loumalouomega loumalouomega deleted the core/missing-remove-constraint branch September 24, 2018 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RiccardoRossi RiccardoRossi RiccardoRossi approved these changes

@adityaghantasala adityaghantasala Awaiting requested review from adityaghantasala

Assignees
No one assigned
Labels
Enhancement FastPR This Pr is simple and / or has been already tested and the revision should be fast Kratos Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loumalouomega @adityaghantasala @RiccardoRossi