Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core][Geometry]Missing methods Prism3D6 #2355

Merged
merged 6 commits into from
Jun 25, 2018
Merged

[Core][Geometry]Missing methods Prism3D6 #2355

merged 6 commits into from
Jun 25, 2018

Conversation

loumalouomega
Copy link
Member

Title says all

@pooyan-dadvand
Copy link
Member

Are there any tests for these modified and added methods?

@loumalouomega
Copy link
Member Author

No, the missing methods are quite standard, but I can add the tests

@loumalouomega
Copy link
Member Author

Tests added

@loumalouomega
Copy link
Member Author

Can anyone approve?

pooyan-dadvand
pooyan-dadvand approved these changes Jun 25, 2018
View reviewed changes
Copy link
Member

@pooyan-dadvand pooyan-dadvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@loumalouomega loumalouomega merged commit 1714b80 into master Jun 25, 2018
@philbucher
Copy link
Member

branch can be deleted?

@loumalouomega loumalouomega deleted the core/prism3D-missing-methods branch June 25, 2018 12:29
@loumalouomega
Copy link
Member Author

Ups

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pooyan-dadvand pooyan-dadvand pooyan-dadvand approved these changes

@RiccardoRossi RiccardoRossi Awaiting requested review from RiccardoRossi

@roigcarlo roigcarlo Awaiting requested review from roigcarlo

Assignees
No one assigned
Labels
Bug Kratos Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loumalouomega @pooyan-dadvand @philbucher