Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GeoMechanicsApplication] Formatted custom_utilities using clang format #12367

Merged
merged 2 commits into from
May 10, 2024
Merged

[GeoMechanicsApplication] Formatted custom_utilities using clang format #12367

merged 2 commits into from
May 10, 2024

Conversation

rfaasse
Copy link
Contributor

@rfaasse rfaasse commented May 10, 2024

No description provided.

@rfaasse rfaasse linked an issue May 10, 2024 that may be closed by this pull request
[GeoMechanicsApplication] Format GeoMechanics code base using clang-format #11919
Closed
@rfaasse rfaasse marked this pull request as ready for review May 10, 2024 10:51
@rfaasse rfaasse requested a review from markelov208 May 10, 2024 11:00
@rfaasse rfaasse enabled auto-merge (squash) May 10, 2024 11:33
markelov208
markelov208 reviewed May 10, 2024
View reviewed changes
Copy link
Contributor

@markelov208 markelov208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Richard, very nice to continue with clang-formatting. I put a few remarks on 'weird inherited order' for matrix elements. I do not know which order should be. The current one just looks strange for me.
It seems SonarCloud will provide a lot of complaints on, for example, nested four for loops. ;(

applications/GeoMechanicsApplication/custom_utilities/interface_element_utilities.hpp Show resolved Hide resolved
applications/GeoMechanicsApplication/custom_utilities/interface_element_utilities.hpp Show resolved Hide resolved
applications/GeoMechanicsApplication/custom_utilities/interface_element_utilities.hpp Show resolved Hide resolved
applications/GeoMechanicsApplication/custom_utilities/interface_element_utilities.hpp Show resolved Hide resolved
applications/GeoMechanicsApplication/custom_utilities/math_utilities.hpp Show resolved Hide resolved
applications/GeoMechanicsApplication/custom_utilities/math_utilities.hpp Show resolved Hide resolved
applications/GeoMechanicsApplication/custom_utilities/math_utilities.hpp Show resolved Hide resolved
applications/GeoMechanicsApplication/custom_utilities/math_utilities.hpp Show resolved Hide resolved
applications/GeoMechanicsApplication/custom_utilities/math_utilities.hpp Show resolved Hide resolved
@rfaasse rfaasse requested a review from markelov208 May 10, 2024 13:02
markelov208
markelov208 approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@markelov208 markelov208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Richard, thank you for checking and clarifications. Let's move to other PRs. ;)

@rfaasse rfaasse merged commit 57b174d into master May 10, 2024
11 checks passed
@rfaasse rfaasse deleted the geo/11919-format-element-utilities-with-clang-format branch May 10, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markelov208 markelov208 markelov208 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[GeoMechanicsApplication] Format GeoMechanics code base using clang-format
2 participants
@rfaasse @markelov208