Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Improve performance in GenerateEntitiesFromConnectivities #12348

Merged

Conversation

loumalouomega
Copy link
Member

@loumalouomega loumalouomega commented May 6, 2024

📝 Description

Improve performance in GenerateEntitiesFromConnectivities, avoid insert, using push_back instead. NOTE: In my mind insert was faster because I thought it did all at once.

🆕 Changelog

@loumalouomega loumalouomega added Kratos Core Performance FastPR This Pr is simple and / or has been already tested and the revision should be fast labels May 6, 2024
@loumalouomega loumalouomega requested a review from a team as a code owner May 6, 2024 11:27
@loumalouomega loumalouomega enabled auto-merge May 6, 2024 11:27
Copy link
Member

@pooyan-dadvand pooyan-dadvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any comparison of the speed for large number of elements?

@loumalouomega loumalouomega merged commit 048e353 into master May 13, 2024
11 checks passed
@loumalouomega loumalouomega deleted the core/improve-performance-in-element-generation branch May 13, 2024 07:52
@loumalouomega
Copy link
Member Author

Do you have any comparison of the speed for large number of elements?

Yes, compared with manually adding (in C++) is twice as fast and with previous version is many times faster.

@loumalouomega
Copy link
Member Author

@roigcarlo do you think we can do a patch for the relase?, kind of 9.5.1?

@roigcarlo
Copy link
Member

If you need one done yes absolutely

@loumalouomega
Copy link
Member Author

If you need one done yes absolutely

Yes, thanks, we are interested on this

@pooyan-dadvand
Copy link
Member

@loumalouomega I would first pass a provisional binary to see if this is really fixed and then we would ask for a hot fix

@loumalouomega
Copy link
Member Author

@loumalouomega I would first pass a provisional binary to see if this is really fixed and then we would ask for a hot fix

Okay I will generate the binaries for them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FastPR This Pr is simple and / or has been already tested and the revision should be fast Kratos Core Performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants