[GeoMechanicsApplication] Simplified fluid flux for pw element #12338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s as an input list
rfaasse
changed the title
This reverts commit 14f8280.
rfaasse
added
Refactor
WPK4FEM
previously approved these changes
May 3, 2024
| mRetentionLawVector[GPoint]->CalculateRelativePermeability(RetentionParameters); | ||
|
|
||
| noalias(GradPressureTerm) = prod(trans(Variables.GradNpT), Variables.PressureVector); | ||
|
|
There was a problem hiding this comment.
lines 1124 and 1126 are constructing the contents of the same variable. This interspacing contradicts that.
avdg81
reviewed
May 3, 2024
| @@ -1112,6 +1091,48 @@ void UPwSmallStrainElement<TDim, TNumNodes>::InitializeBiotCoefficients(ElementV | |||
| KRATOS_CATCH("") | |||
| } | |||
|
|
|||
| template <unsigned int TDim, unsigned int TNumNodes> | |||
| std::vector<array_1d<double, TDim>> UPwSmallStrainElement<TDim, TNumNodes>::CalculateFluidFluxes( | |||
| const std::vector<double>& permeability_update_factors, const ProcessInfo& rCurrentProcessInfo) | |||
There was a problem hiding this comment.
To be in line with the Kratos Style Guide, we should rename the first parameter:
Suggested change
| const std::vector<double>& permeability_update_factors, const ProcessInfo& rCurrentProcessInfo) | |
| const std::vector<double>& rPermeabilityUpdateFactors, const ProcessInfo& rCurrentProcessInfo) |
…d_fluid_flux_for_Pw_element
WPK4FEM
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
We found that to calculate the fluid flux variable, the permeability update factor was calculated using strains, regardless of Pw vs UPw. Since strains are meaningless for Pw elements, this needed to be rectified. Therefore, a function is created to calculate fluid fluxes, which takes as an input a list of permeability update factors for the integration points (which are now always 1 for the Pw elements and calculated via the strain for UPw elements).