[Core] AMGCL NS - Allow using different var for pressure #11687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loumalouomega
approved these changes
Oct 17, 2023
roigcarlo
reviewed
Oct 17, 2023
ddiezrod
deleted the
core/amgcl-ns-add-option-to-use-other-vars-for-pressure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
AMGCL_NS already allows using any variable for pressure (not just PRESSURE) from parameters. However, this setting is not being used later. Here I make sure that when pmask is built, the correct variable is used.
FYI @pablobecker @pooyan-dadvand