-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GeoMechanicsApplication] Isolated Hencky strain computation, such that it appears once. #11667
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice that we got rid of another duplicate function and added a unit test! I have some suggestions and questions, but none of them are really blocking.
applications/GeoMechanicsApplication/custom_elements/U_Pw_small_strain_element.cpp
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_utilities/stress_strain_utilities.hpp
Show resolved
Hide resolved
applications/GeoMechanicsApplication/tests/cpp_tests/test_Hencky_strain.cpp
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_utilities/stress_strain_utilities.hpp
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/tests/cpp_tests/test_Hencky_strain.cpp
Show resolved
Hide resolved
applications/GeoMechanicsApplication/tests/cpp_tests/test_Hencky_strain.cpp
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/tests/cpp_tests/test_Hencky_strain.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done, nice cleanup!
applications/GeoMechanicsApplication/custom_elements/small_strain_U_Pw_diff_order_element.cpp
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/tests/cpp_tests/test_Hencky_strain.cpp
Outdated
Show resolved
Hide resolved
…tretch, rigid rotation and pure shear unit tests.
d1d7d20
to
44198b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go!
The computation of Hencky strain ( logarithmic strain or natural strain ) has been moved from the element implementations to stress_strain_utilities, such that code duplication is avoided.
Added stretch, rigid rotation and pure shear unit tests.