[CoSimulationApplication] Adding AcuSolve wrapper
#11512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philbucher
previously approved these changes
Aug 28, 2023
| else: | ||
| cmd = "acuRun.bat -inp "+inputFile+" -pb "+problem+" -dir "+working_directory+" -pdir "+problem_directory+" -np "+str(np)+" -nt "+str(nt)+" -verbose "+str(echo_level)+" -lbuff" | ||
| cs_tools.cs_print_info(self.name + ": " + cmd) | ||
| subprocess.Popen(cmd) |
There was a problem hiding this comment.
subprocess.run is the newer and safer alternative
There was a problem hiding this comment.
It was unused, replaced with os.system (common for Linux/windows)
| self.vtk_output = VtkOutputProcess(self.model, vtk_output_configuration) | ||
| self.vtk_output.ExecuteInitialize() | ||
| self.vtk_output.ExecuteBeforeSolutionLoop() | ||
| self.vtk_output.PrintOutput() |
There was a problem hiding this comment.
Implementation is not mine...
philbucher
reviewed
Aug 28, 2023
| # Python exception in case not detected OS | ||
| raise Exception("Unsupported operating system detected.") | ||
| cs_tools.cs_print_info(self.name + ": " + cmd) | ||
| os.system(cmd) |
There was a problem hiding this comment.
That is even worse 😅 (talking mainly about security issues, had sth similar at work)
I recommend using subprocess.run
|
Then it will be... Tomorrow
El lun., 28 ago. 2023 20:09, Philipp Bucher ***@***.***>
escribió:
… ***@***.**** commented on this pull request.
------------------------------
In
applications/CoSimulationApplication/python_scripts/solver_wrappers/external/acusolve_wrapper.py
<#11512 (comment)>
:
> + elif platform == "win32":
+ base_cmd = "acuRun.bat -inp "
+ buffer_cmd = " -lbuff"
+ if gpu != "FALSE":
+ cmd = base_cmd + common_cmd + " -gpu " + gpu + verbose_cmd + buffer_cmd
+ elif rst != "FALSE":
+ cmd = base_cmd + common_cmd + " -rst " + verbose_cmd + buffer_cmd
+ elif frst != "FALSE":
+ cmd = base_cmd + common_cmd + " -frst " + verbose_cmd + buffer_cmd
+ else:
+ cmd = base_cmd + common_cmd + verbose_cmd + buffer_cmd
+ else:
+ # Python exception in case not detected OS
+ raise Exception("Unsupported operating system detected.")
+ cs_tools.cs_print_info(self.name + ": " + cmd)
+ os.system(cmd)
That is even worse 😅 (talking mainly about security issues, had sth
similar at work)
I recommend using subprocess.run
—
Reply to this email directly, view it on GitHub
<#11512 (review)>,
or unsubscribe
</~https://github.com/notifications/unsubscribe-auth/AEYQZADGSZY5IMQKOSBOX6LXXTNGHANCNFSM6AAAAAA4BGCQBQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR introduces a new CoSimulation wrapper called
acuSolveWrapperthat serves as a dedicated Kratos wrapper for theacuSolvesolver.NOTE: This wrapper class was not developed by me, the details I can provide are limited.
The contents of the commit include the following changes:
acuSolveWrapperclass that extendsCoSimulationSolverWrapper.Initializefunction for theacuSolveWrapperclass to perform additional initialization tasks, such as importing coupling interfaces and configuring VTK output settings.🆕 Changelog
AcuSolvewrapper