Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with identical cache keys between projects #636

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

remcomokveld
Copy link
Contributor

Fixes #633

@remcomokveld
Copy link
Contributor Author

Actually, a good point was raised here that this task should probably not be cacheable, and I'm actually doubtful whether this task should exist at all. I don't think it would ever be quicker to write and then read this data from disk compared to just recomputing it every time in the places where this is used.

Especially on projects with a remote build cache where, in the absence of a valid output a network request would be done to check for remote entries.

See docs here https://docs.gradle.org/current/userguide/build_cache.html#sec:task_output_caching_disabled_by_default

Thoughts on either disabling caching or completely removing the task?

@shanshin
Copy link
Collaborator

Hi, thanks for the effort!

We have thought about various options and at the moment we decided to try to disable the build cache for this task.

However, the behavior should be fixed, i.e. it should work with the build cache enabled. Therefore, we should merge this PR and later #637.

@shanshin shanshin self-requested a review June 18, 2024 10:33
@shanshin shanshin merged commit 85c5881 into Kotlin:main Jun 18, 2024
@remcomokveld remcomokveld deleted the artifact-cache-issue branch June 18, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

koverCachedVerify failure due to incorrect paths in the .artifact file
2 participants