fix: don't build diff doc for creates and deletes #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a 'visual' regression introduced in #463, which is making decK print full diff documents for 'create' and 'delete' actions. This can result in very verbose output in case of configuration files containing hundreds/thousands of resources.
GGabriele
temporarily deployed
to
Configure ci
GitHub Actions
Inactive
Codecov ReportBase: 38.88% // Head: 38.91% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #806 +/- ##
==========================================
+ Coverage 38.88% 38.91% +0.03%
==========================================
Files 88 88
Lines 10205 10197 -8
==========================================
Hits 3968 3968
+ Misses 5851 5843 -8
Partials 386 386
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
aboudreault
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a 'visual' regression introduced in #463, which is making decK print full diff documents for 'create' and 'delete' actions. This can result in very
verbose output in case of configuration files
containing hundreds/thousands of resources.