fix(cmd) use separate variables for Konnect flags #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use separate variables to store Konnect command flag values where Konnect commands share flags with non-Konnect commands. Cobra will otherwise update the variable contents with whichever flags it processes last, effectively overriding the non-Konnect defaults with the Konnect defaults. Fix #288
mflendrich
approved these changes
Mar 19, 2021
There was a problem hiding this comment.
This problem is a perfect example of why we should avoid global state in decK.
Thanks @rainest for fixing this.
I recommend that we go further and isolate konnect commands into a subpackage.
rainest
pushed a commit
that referenced
this pull request
Apr 21, 2021
Use separate variables to store Konnect command flag values where Konnect commands share flags with non-Konnect commands. Cobra will otherwise update the variable contents with whichever flags it processes last, effectively overriding the non-Konnect defaults with the Konnect defaults. Fix #288
AntoineJac
pushed a commit
that referenced
this pull request
Jan 23, 2024
Use separate variables to store Konnect command flag values where Konnect commands share flags with non-Konnect commands. Cobra will otherwise update the variable contents with whichever flags it processes last, effectively overriding the non-Konnect defaults with the Konnect defaults. Fix #288
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use separate variables to store Konnect command flag values where Konnect commands share flags with non-Konnect commands.
Cobra will otherwise update the variable contents with whichever flags it processes last, effectively overriding the non-Konnect defaults with the Konnect defaults.
I don't think anything wants a different default value currently other than the state file, but I think we should define new variables for everything that's not actually being inherited from a parent command for consistency and safety in the event of future changes to one command set's defaults.
Fix #288