Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#118 Introduce FragmentOperation API. #119

Merged
merged 1 commit into from
Mar 12, 2020

Conversation

tomaszmichalak
Copy link
Member

@tomaszmichalak tomaszmichalak commented Mar 11, 2020

Fix #118 .

Upgrade notes

We've moved FragmentContext and FragmentResult from knotx-fragments-engine-api to knotx-fragments-api so please update all imports from:

io.knotx.fragments.engine.api.node.single.FragmentContext
io.knotx.fragments.engine.api.node.single.FragmentResult

to:

io.knotx.fragments.api.FragmentContext
io.knotx.fragments.api.FragmentResult

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

I hereby agree to the terms of the Knot.x Contributor License Agreement.

@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #119 into master will increase coverage by 0.28%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #119      +/-   ##
============================================
+ Coverage     87.63%   87.91%   +0.28%     
+ Complexity     1420     1418       -2     
============================================
  Files           148      147       -1     
  Lines          6033     6034       +1     
  Branches        185      184       -1     
============================================
+ Hits           5287     5305      +18     
+ Misses          653      636      -17     
  Partials         93       93
Impacted Files Coverage Δ Complexity Δ
...st/java/io/knotx/fragments/engine/Transitions.java 100% <ø> (ø) 2 <0> (ø) ⬇️
...ction/http/response/EndpointResponseProcessor.java 92.98% <ø> (ø) 26 <0> (ø) ⬇️
...factory/node/subtasks/SubtasksNodeFactoryTest.java 98.86% <ø> (ø) 14 <0> (ø) ⬇️
...logging/InlinePayloadActionFactoryLoggingTest.java 88.88% <ø> (ø) 8 <0> (ø) ⬇️
...st/java/io/knotx/fragments/handler/TestAction.java 100% <ø> (ø) 4 <0> (ø) ⬇️
...nts/handler/action/PayloadToBodyActionFactory.java 85% <ø> (ø) 9 <0> (ø) ⬇️
.../fragments/handler/action/http/HttpActionTest.java 99.53% <ø> (ø) 68 <0> (ø) ⬇️
...main/java/io/knotx/fragments/handler/api/Knot.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...gments/handler/action/InlineBodyActionFactory.java 95.83% <ø> (ø) 7 <0> (ø) ⬇️
...ndler/consumer/html/GraphNodeExecutionLogTest.java 100% <ø> (ø) 3 <0> (ø) ⬇️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffa6866...1151995. Read the comment docs.

@tomaszmichalak tomaszmichalak force-pushed the feature/fragment-operation-api branch from 75a6001 to 1151995 Compare March 12, 2020 08:46
@tomaszmichalak tomaszmichalak merged commit a3a47d1 into master Mar 12, 2020
@tomaszmichalak tomaszmichalak deleted the feature/fragment-operation-api branch March 12, 2020 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Actions have no common interface with SingleNode
2 participants