#92 Provide task metadata to event consumer. Expose in debug script. #104

marcinus · 2020-02-14T18:02:28Z

Provides a maintainable way to append metadata to Tasks.
The metadata creation is integrated in DefaultTaskFactory and NodeFactories (Action and Subtask).
The metadata is then provided to the consumer and can be exposed in HTML.

Description

Task definition now contains an optional JsonObject field metadata.
DefaultTaskFactory makes use of this field to provide metadata that is generated from configuration.
NodeFactory interface is enhanced with a default method for returning node's metadata.
This method is overriden in ActionNodeFactory and SubtaskNodeFactory.
FragmentsEngine is changed to return full FragmentEventContextTaskAware for potential future reuse.

Motivation and Context

Relates to #92

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.

I hereby agree to the terms of the Knot.x Contributor License Agreement.

handler/engine/src/main/java/io/knotx/fragments/engine/Task.java

codecov · 2020-02-24T12:58:32Z

Codecov Report

Merging #104 into master will not change coverage by %.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #104   +/-   ##
=========================================
  Coverage     87.56%   87.56%           
  Complexity     1415     1415           
=========================================
  Files           148      148           
  Lines          6000     6000           
  Branches        185      185           
=========================================
  Hits           5254     5254           
  Misses          653      653           
  Partials         93       93

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e945ff6...e945ff6. Read the comment docs.

handler/core/src/main/java/io/knotx/fragments/engine/NodeMetadata.java

…-fragments into feature/expose-task-metadata

handler/core/src/main/java/io/knotx/fragments/handler/consumer/metadata/EventLogConverter.java

handler/core/src/main/java/io/knotx/fragments/handler/consumer/metadata/MetadataConverter.java

handler/core/src/main/java/io/knotx/fragments/task/factory/node/action/ActionNodeFactory.java

…-fragments into feature/expose-task-metadata

…-fragments into feature/expose-task-metadata � Conflicts: � handler/core/src/test/java/io/knotx/fragments/handler/consumer/metadata/MetadataConverterTest.java

…-fragments into feature/expose-task-metadata # Conflicts: # handler/core/src/main/java/io/knotx/fragments/task/factory/node/action/ActionProvider.java

handler/core/src/main/java/io/knotx/fragments/handler/LoggedNodeStatus.java

handler/core/src/main/java/io/knotx/fragments/handler/ExecutionPlan.java

#92 add response json models

tomaszmichalak force-pushed the feature/expose-task-metadata branch from 8dc5c30 to 9d2999d Compare February 17, 2020 08:48

tomaszmichalak reviewed Feb 17, 2020

View reviewed changes

handler/engine/src/main/java/io/knotx/fragments/engine/Task.java Outdated Show resolved Hide resolved

marcinus force-pushed the feature/expose-task-metadata branch from 55ce510 to fc22860 Compare February 22, 2020 21:07

marcin.szymura and others added 4 commits February 24, 2020 12:14

#92 Provide task metadata to event consumer. Expose in debug script.

8538946

#92 Provide alternative implementation of exposing Task Graph metadata.

0f86541

#92 Fix regression in Fragment Processing. Make consumer more null-safe.

ea5aa91

#92 Rebase with master.

93ef44f

tomaszmichalak force-pushed the feature/expose-task-metadata branch from fc22860 to 93ef44f Compare February 24, 2020 11:43

#92 Rebase with master.

062f050

marcin.szymura added 2 commits February 24, 2020 16:13

#92 Unit tests for MetadataConverter.

5688495

#92 Wrap single invocation log with JsonArray in MetadataConverter.

b00a7c6

tomaszmichalak reviewed Feb 24, 2020

View reviewed changes

tomaszmichalak and others added 10 commits February 25, 2020 12:36

#92 remove factory from node metadata

9b991a1

#92 Introduce factory methods for single / composite node matadata.

d546fc2

#92 Unit test for EventLogConverter. Handle NodeStatus.UNPROCESSED.

7ef2a4f

#92 Unit test for EventLogConverter. Handle NodeStatus.UNPROCESSED.

afd1ee9

#92 Adding OperationMetadata model.

01cc5ac

Merge branch 'feature/expose-task-metadata' of github.com:Knotx/knotx…

270590b

…-fragments into feature/expose-task-metadata

#92 Unique nodeId for missing nodes.

c46134a

#92 Unify log and graph debug data into single data structure.

1165e8b

#92 Add label field to NodeMetadata. Action alias is the default label.

5c40425

#92 Improve action factory tests with TODO left.

743d63a

Voycawojka reviewed Mar 2, 2020

View reviewed changes

handler/core/src/main/java/io/knotx/fragments/handler/consumer/metadata/EventLogConverter.java Outdated Show resolved Hide resolved

Voycawojka reviewed Mar 2, 2020

View reviewed changes

handler/core/src/main/java/io/knotx/fragments/handler/consumer/metadata/MetadataConverter.java Outdated Show resolved Hide resolved

Voycawojka reviewed Mar 2, 2020

View reviewed changes

handler/core/src/main/java/io/knotx/fragments/task/factory/node/action/ActionNodeFactory.java Outdated Show resolved Hide resolved

tomaszmichalak and others added 4 commits March 2, 2020 12:23

#92 Improve subtasks factory tests with TODO left.

d413e22

#92 Added javadocs, fixed default task factory method reference.

5845fbb

#92 default task factory test cleanup.

dbae417

#92 Fix subtasks node factory tests so they don't crash

d02dcb4

Voycawojka and others added 18 commits March 3, 2020 16:51

#92 Fix tests, adjust log statuses

50be8c9

#92 node factory tests.

771523e

#92 composite node metadata test.

8bb7ac0

#92 javadoc fix.

bd72cdc

#92 refactor event log converter logic

05c4691

Merge branch 'feature/expose-task-metadata' of github.com:Knotx/knotx…

bd14d71

…-fragments into feature/expose-task-metadata

#92 Introduce node execution data class.

5ec77b3

#92 Adjust metadata converter

d6bda62

Merge branch 'feature/expose-task-metadata' of github.com:Knotx/knotx…

55cc31a

…-fragments into feature/expose-task-metadata � Conflicts: � handler/core/src/test/java/io/knotx/fragments/handler/consumer/metadata/MetadataConverterTest.java

Refactor LoggedNodeStatus enum

489aaa8

Refactor EventLogConverter

5894d16

#92 Adjust json structure to match frontend contract

41b5e79

#92 Cover LoggedNodeStatus with tests

0554841

#92 Fix CodeFactor issues

40121bd

#92 Refactor caching mechanism in ActionProvider

ab3f944

#92 Revert changes in Action provider.

a59c8e8

Merge branch 'feature/expose-task-metadata' of github.com:Knotx/knotx…

3fffeeb

…-fragments into feature/expose-task-metadata # Conflicts: # handler/core/src/main/java/io/knotx/fragments/task/factory/node/action/ActionProvider.java

#92 remove redundant dependencies, added license headers.

5e45ad6

tomaszmichalak reviewed Mar 9, 2020

View reviewed changes

handler/core/src/main/java/io/knotx/fragments/handler/LoggedNodeStatus.java Show resolved Hide resolved

handler/core/src/main/java/io/knotx/fragments/handler/ExecutionPlan.java Show resolved Hide resolved

tomaszmichalak added 2 commits March 10, 2020 13:53

#92 add response json models (#116)

8122cdd

#92 add response json models

#92 CR fixes.

e945ff6

tomaszmichalak approved these changes Mar 10, 2020

View reviewed changes

tomaszmichalak merged commit ffa6866 into master Mar 10, 2020

This was referenced Mar 11, 2020

Fragment event start / stop timestamps #110

Closed

Unique node id #93

Closed

tomaszmichalak deleted the feature/expose-task-metadata branch March 11, 2020 16:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#92 Provide task metadata to event consumer. Expose in debug script. #104

#92 Provide task metadata to event consumer. Expose in debug script. #104

marcinus commented Feb 14, 2020

codecov bot commented Feb 24, 2020 •

edited

Loading

#92 Provide task metadata to event consumer. Expose in debug script. #104

#92 Provide task metadata to event consumer. Expose in debug script. #104

Conversation

marcinus commented Feb 14, 2020

Description

Motivation and Context

Types of changes

Checklist:

codecov bot commented Feb 24, 2020 • edited Loading

Codecov Report

codecov bot commented Feb 24, 2020 •

edited

Loading