feat: increase service URL size limit #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ad96el
approved these changes
Feb 12, 2024
weichweich
approved these changes
Feb 12, 2024
ChrisChinchilla
pushed a commit
that referenced
this pull request
Feb 16, 2024
Fixes /~https://github.com/KILTprotocol/ticket/issues/3131. The ticket mentions that 500 would be a good new limit for the inbound request we had. Reading elsewhere online, such as [here](https://stackoverflow.com/a/417184) it seems that 2000 characters is a good upper bound limit for URLs. Since every change would require a runtime upgrade, I would rather make the value future proof and set it to 2000 directly.
Ad96el
pushed a commit
that referenced
this pull request
Apr 2, 2024
Fixes KILTprotocol/ticket#3131. The ticket mentions that 500 would be a good new limit for the inbound request we had. Reading elsewhere online, such as [here](https://stackoverflow.com/a/417184) it seems that 2000 characters is a good upper bound limit for URLs. Since every change would require a runtime upgrade, I would rather make the value future proof and set it to 2000 directly.
ntn-x2
added a commit
that referenced
this pull request
Apr 4, 2024
Fixes KILTprotocol/ticket#3131. The ticket mentions that 500 would be a good new limit for the inbound request we had. Reading elsewhere online, such as [here](https://stackoverflow.com/a/417184) it seems that 2000 characters is a good upper bound limit for URLs. Since every change would require a runtime upgrade, I would rather make the value future proof and set it to 2000 directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes /~https://github.com/KILTprotocol/ticket/issues/3131.
The ticket mentions that 500 would be a good new limit for the inbound request we had. Reading elsewhere online, such as here it seems that 2000 characters is a good upper bound limit for URLs. Since every change would require a runtime upgrade, I would rather make the value future proof and set it to 2000 directly.