Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add clone 3 #597

Merged
merged 14 commits into from
Dec 20, 2023
Merged

feat: add clone 3 #597

merged 14 commits into from
Dec 20, 2023

Conversation

weichweich
Copy link
Contributor

fixes KILTProtocol/ticket#312

Checklist:

  • I have verified that the code works
    • No panics! (checked arithmetic ops, no indexing array[3] use get(3), ...)
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)
    • Either PR or Ticket to update the Docs
    • Link the PR/Ticket here

@weichweich weichweich marked this pull request as ready for review December 18, 2023 09:05
@weichweich weichweich requested review from Ad96el and ntn-x2 December 18, 2023 09:05
parameter_types! {
pub RelayChainOrigin: RuntimeOrigin = cumulus_pallet_xcm::Origin::Relay.into();
pub Ancestry: MultiLocation = Parachain(ParachainInfo::parachain_id().into()).into();
// TODO: This needs to be updated once we deploy Peregrine on Rococo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed.

@weichweich weichweich enabled auto-merge (squash) December 20, 2023 12:01
@weichweich weichweich merged commit 3a3ffa4 into develop Dec 20, 2023
2 checks passed
@weichweich weichweich deleted the aw-clone-3 branch December 20, 2023 12:27
ChrisChinchilla pushed a commit that referenced this pull request Feb 16, 2024
## fixes KILTProtocol/ticket#312


## Checklist:

- [ ] I have verified that the code works
- [ ] No panics! (checked arithmetic ops, no indexing `array[3]` use
`get(3)`, ...)
- [ ] I have verified that the code is easy to understand
  - [ ] If not, I have left a well-balanced amount of inline comments
- [ ] I have [left the code in a better
state](https://deviq.com/principles/boy-scout-rule)
- [ ] I have documented the changes (where applicable)
* Either PR or Ticket to update [the
Docs](/~https://github.com/KILTprotocol/docs)
    * Link the PR/Ticket here

---------

Co-authored-by: Adel Golghalyani <ad96el@gmail.com>
Ad96el added a commit that referenced this pull request Apr 2, 2024
## fixes KILTprotocol/ticket#312


## Checklist:

- [ ] I have verified that the code works
- [ ] No panics! (checked arithmetic ops, no indexing `array[3]` use
`get(3)`, ...)
- [ ] I have verified that the code is easy to understand
  - [ ] If not, I have left a well-balanced amount of inline comments
- [ ] I have [left the code in a better
state](https://deviq.com/principles/boy-scout-rule)
- [ ] I have documented the changes (where applicable)
* Either PR or Ticket to update [the
Docs](/~https://github.com/KILTprotocol/docs)
    * Link the PR/Ticket here

---------

Co-authored-by: Adel Golghalyani <ad96el@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants