chore: polkadot 0.9.42 migration #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ad96el
force-pushed
the
chore/polkadot-0.9.42_migration
branch
from
a597e10 to
8b0e6ff
Compare
Ad96el
requested review from
ntn-x2 and
weichweich
and removed request for
ntn-x2
Ad96el
force-pushed
the
chore/polkadot-0.9.42_migration
branch
from
53a6e7d to
58b6845
Compare
ntn-x2
reviewed
Jul 24, 2023
ntn-x2
reviewed
Sep 14, 2023
| pub(crate) BoundedVec<u8, T::MaxNameLength>, | ||
| PhantomData<(T, T::MinNameLength)>, | ||
| ); | ||
| pub struct AsciiWeb3Name<T: Config>(pub BoundedVec<u8, T::MaxNameLength>, PhantomData<(T, T::MinNameLength)>); |
There was a problem hiding this comment.
I would rather expose a into_inner() function on the struct than making the bounded vec leak to other crates.
…ocol/kilt-node into chore/polkadot-0.9.42_migration
ntn-x2
reviewed
Sep 15, 2023
ntn-x2
approved these changes
Oct 10, 2023
| @@ -29,25 +27,28 @@ mod mock; | |||
| #[cfg(test)] | |||
| mod test; | |||
|
|
|||
| pub use crate::{default_weights::WeightInfo, pallet::*}; | |||
There was a problem hiding this comment.
I think this should only be imported inside the pallet module.
Ad96el
force-pushed
the
chore/polkadot-0.9.42_migration
branch
from
ed20e23 to
a375f3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #2799
Follow-up PR for the migration.