Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify set_solver_specific! #63

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Simplify set_solver_specific! #63

merged 1 commit into from
Feb 27, 2023

Conversation

tmigot
Copy link
Member

@tmigot tmigot commented Feb 22, 2023

Close #30

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Base: 96.36% // Head: 97.36% // Increases project coverage by +0.99% 🎉

Coverage data is based on head (781fce4) compared to base (e99174d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
+ Coverage   96.36%   97.36%   +0.99%     
==========================================
  Files           5        5              
  Lines         303      304       +1     
==========================================
+ Hits          292      296       +4     
+ Misses         11        8       -3     
Impacted Files Coverage Δ
src/stats.jl 97.54% <100.00%> (+1.86%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

Package name latest stable
CaNNOLeS.jl
DCISolver.jl
DerivativeFreeSolvers.jl
FletcherPenaltySolver.jl
JSOSolvers.jl
NLPModelsIpopt.jl
Percival.jl
RipQP.jl
SolverBenchmark.jl
SolverTest.jl

Copy link
Member

@abelsiqueira abelsiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@tmigot tmigot merged commit b76f1ff into main Feb 27, 2023
@tmigot tmigot deleted the save-allocs-specific branch February 27, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluate if solver_specific makes solve! type unstable
3 participants