-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated module for Julia v1.5 #122
Conversation
- examples not updated - added some more indicators
- examples are missing - added indicators
Updated tests to Julia v1.1/TimeSeries v0.14
Codecov Report
@@ Coverage Diff @@
## master #122 +/- ##
===========================================
- Coverage 94.11% 59.75% -34.37%
===========================================
Files 7 8 +1
Lines 221 410 +189
===========================================
+ Hits 208 245 +37
- Misses 13 165 +152
Continue to review full report at Codecov.
|
Co-authored-by: Iblis Lin <iblis@hs.ntnu.edu.tw>
floorpivots(ohlc) | ||
|
||
Floor Trader Pivots | ||
|
||
```math | ||
\begin{align*} | ||
'begin{align*} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, I will file the doc rendering issue as another issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to merge this first and add test cases, improve code quality, improve doc later. |
Any ideas about the 1.0 Job failure ? https://travis-ci.com/github/JuliaQuant/MarketTechnicals.jl/jobs/380608195 |
In Julia 1.0 they had only these type signatures diff(A::AbstractVector)
diff(A::AbstractMatrix; dims::Integer) /~https://github.com/JuliaLang/julia/blob/v1.1.0/base/multidimensional.jl From julia 1.1 they included AbstractArray diff(A::AbstractVector)
diff(A::AbstractArray; dims::Integer) |
No description provided.