Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated module for Julia v1.5 #122

Merged
merged 27 commits into from
Sep 3, 2020
Merged

Conversation

astadmistry
Copy link
Contributor

No description provided.

Manifest.toml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #122 into master will decrease coverage by 34.36%.
The diff coverage is 51.22%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #122       +/-   ##
===========================================
- Coverage   94.11%   59.75%   -34.37%     
===========================================
  Files           7        8        +1     
  Lines         221      410      +189     
===========================================
+ Hits          208      245       +37     
- Misses         13      165      +152     
Impacted Files Coverage Δ
src/momentum.jl 32.70% <21.89%> (-67.30%) ⬇️
src/volume.jl 47.61% <41.30%> (-42.04%) ⬇️
src/utilities.jl 86.48% <80.76%> (-13.52%) ⬇️
src/MarketTechnicals.jl 100.00% <100.00%> (ø)
src/candlesticks.jl 10.00% <100.00%> (-8.19%) ⬇️
src/levels.jl 89.47% <100.00%> (-4.98%) ⬇️
src/movingaverages.jl 100.00% <100.00%> (ø)
src/volatility.jl 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c32d66d...b2a3880. Read the comment docs.

.travis.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
floorpivots(ohlc)

Floor Trader Pivots

```math
\begin{align*}
'begin{align*}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, I will file the doc rendering issue as another issue

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iblislin
Copy link
Member

iblislin commented Sep 3, 2020

I want to merge this first and add test cases, improve code quality, improve doc later.
There are a few indicators added, but I don't check the detail of algorithm yet.

@iblislin
Copy link
Member

iblislin commented Sep 3, 2020

Any ideas about the 1.0 Job failure ? https://travis-ci.com/github/JuliaQuant/MarketTechnicals.jl/jobs/380608195

@astadmistry
Copy link
Contributor Author

astadmistry commented Sep 3, 2020

/~https://github.com/JuliaLang/julia/blob/5d4eaca0c9fa3d555c79dbacdccb9169fdf64b65/base/multidimensional.jl

In Julia 1.0 they had only these type signatures

diff(A::AbstractVector)
diff(A::AbstractMatrix; dims::Integer)

/~https://github.com/JuliaLang/julia/blob/v1.1.0/base/multidimensional.jl

From julia 1.1 they included AbstractArray

diff(A::AbstractVector)
diff(A::AbstractArray; dims::Integer)

Project.toml Outdated Show resolved Hide resolved
@iblislin iblislin merged commit 61a76ac into JuliaQuant:master Sep 3, 2020
@Arkoniak Arkoniak mentioned this pull request Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants