Prefix parent package name to extension names #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ven-k
commented
May 5, 2023
•
ven-k
commented
- This prevents clash of extension names.
- Currently, clashes with Accessors.jl.
- And clashing names throw fatal errors while building sysimages.
- See: Prefix parent package name to extension names Accessors.jl#104
Codecov ReportPatch and project coverage have no change.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #78 +/- ##
=======================================
Coverage 35.21% 35.21%
=======================================
Files 5 5
Lines 142 142
=======================================
Hits 50 50
Misses 92 92
☔ View full report in Codecov by Sentry. |
|
Awesome, thanks!
You consider this is a breaking change? Can you elaborate? |
- this prevents clash of extension names
ven-k
changed the title
|
Ah oversight. I meant to use |
|
Can you bump the patch version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.