Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add intervalsets and staticarrays support #69

Merged
merged 4 commits into from
Feb 17, 2023

Conversation

aplavin
Copy link
Member

@aplavin aplavin commented Dec 16, 2022

Would automatically support staticarrays and intervals on Julia 1.9+, nothing changes on earlier versions.

Extensions follow https://pkgdocs.julialang.org/dev/creating-packages/#Conditional-loading-of-code-in-packages-(Extensions).
Integration implementations themselves are copied directly from /~https://github.com/JuliaObjects/ConstructionBaseExtras.jl. ConstructionBaseExtras would become obsolete on 1.9+.

Don't merge yet: Registrator hasn't been updated to support extensions.

@aplavin aplavin force-pushed the master branch 2 times, most recently from b8cabde to dbac68d Compare December 16, 2022 12:52
@rafaqz
Copy link
Member

rafaqz commented Dec 16, 2022

Amazing.

This was the main use case I argued for in the old glue packages discussion.

And yes we can finally archive CBE when v1.9 is out, I had given up hope this would happen.

@aplavin
Copy link
Member Author

aplavin commented Jan 26, 2023

Weakdeps were added to registrator, I think this can be merged and tagged now!

test/runtests.jl Outdated Show resolved Hide resolved
Copy link
Member

@jw3126 jw3126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks! Looks good only a few minor comments above.

@aplavin
Copy link
Member Author

aplavin commented Feb 5, 2023

bump

@aplavin
Copy link
Member Author

aplavin commented Feb 17, 2023

Can this be merged?..

@jw3126 jw3126 merged commit 4d661f8 into JuliaObjects:master Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants