-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add intervalsets and staticarrays support #69
Conversation
b8cabde
to
dbac68d
Compare
Amazing. This was the main use case I argued for in the old glue packages discussion. And yes we can finally archive CBE when v1.9 is out, I had given up hope this would happen. |
Weakdeps were added to registrator, I think this can be merged and tagged now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks! Looks good only a few minor comments above.
bump |
Can this be merged?.. |
Would automatically support staticarrays and intervals on Julia 1.9+, nothing changes on earlier versions.
Extensions follow https://pkgdocs.julialang.org/dev/creating-packages/#Conditional-loading-of-code-in-packages-(Extensions).
Integration implementations themselves are copied directly from /~https://github.com/JuliaObjects/ConstructionBaseExtras.jl.
ConstructionBaseExtras
would become obsolete on 1.9+.Don't merge yet: Registrator hasn't been updated to support extensions.