add bufferWithStyle #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
visr
reviewed
Oct 18, 2018
src/geos_functions.jl
Outdated
| @@ -324,6 +324,9 @@ end | |||
| buffer(ptr::GEOSGeom, width::Real, quadsegs::Integer=8, context::GEOSContext = _context) = | |||
| GEOSBuffer_r(context.ptr, ptr, width, Int32(quadsegs)) | |||
|
|
|||
| bufferWithStyle(ptr::GEOSGeom, width::Real, quadsegs::Integer=8, endCapStyle::Integer=1, joinStyle::Integer=1, mitreLimit::Real=5.0, context::GEOSContext = _context) = | |||
| GEOSBufferWithStyle_r(context.ptr, ptr, width, Int32(quadsegs), Int32(endCapStyle), Int32(joinStyle), mitreLimit) | |||
|
|
|||
| # enum GEOSBufCapStyles | |||
| # enum GEOSBufJoinStyles | |||
There was a problem hiding this comment.
Could you perhaps add these as well, and use them instead of integers as input argument type for bufferWithStyle?
That way it will be easier for users to find out about the different possible styles.
See for instance this example:
/~https://github.com/JuliaGeo/GDAL.jl/blob/38ccd2d37664673b81b1a86e9947bd5fe9a2f6d2/src/common.jl#L102
/~https://github.com/JuliaGeo/GDAL.jl/blob/017bf6b8492dcd2186ced297076b283c3591d798/src/gdal_h.jl#L14
visr
requested changes
Oct 18, 2018
|
Sure, will add tests later today. |
optional arguments as keyword arguments
|
Tests added. Checks are passing. Should be ready to go. A matter of taste if |
|
I'm okay with not exporting the enums for now. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap
GEOSBufferWithStyleasbufferWithStylesimilarly likeGEOSBufferasbuffer.I set default for
mitreLimit5.0, same as in the library/~https://github.com/libgeos/geos/blob/8a9600bb2e617c788fdcdad8eb9e9045925bbd23/src/operation/buffer/BufferParameters.cpp#L35
Defaults for
endCapStyle1 (CAP_ROUND) andjoinStyle1 (JOIN_ROUND).