Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message for not-implemented geometric types #212

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Improve error message for not-implemented geometric types #212

merged 1 commit into from
Jan 12, 2025

Conversation

jaakkor2
Copy link
Contributor

Master

julia> readgeom("CIRCULARSTRING(0 0,1 1,2 0)")
ERROR: AssertionError: id == GEOS_GEOMETRYCOLLECTION

This PR

julia> readgeom("CIRCULARSTRING(0 0,1 1,2 0)")
ERROR: Geometric type with code 8 not implemented.

@jaakkor2
Copy link
Contributor Author

Test failure is upstream libgeos/geos#1198, considered in #211. No upstream 3.13.1 or 3.14.0 is yet released.

visr
visr approved these changes Jan 12, 2025
View reviewed changes
Copy link
Member

@visr visr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's better indeed.

@visr visr merged commit 77f0b8b into JuliaGeo:master Jan 12, 2025
0 of 9 checks passed
@jaakkor2 jaakkor2 deleted the errornotimplemented branch January 13, 2025 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visr visr visr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaakkor2 @visr