Refactor GeoInterface implementation. #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaqz
reviewed
Mar 13, 2023
|
Would be good to merge this... |
|
Thanks for the bump. Will try to address your comments later this week. |
|
@rafaqz This should be good to go now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should partially fix #160.
Made ngeom to be stable, was a Union{Int64, Int32} before.
coordinates(multipolygon)can now be correctly inferred.It's a bit ugly to define thing(AbstractPoint, NonPoint), but it's required for the ambiguity checks. Might be good to understand why this is required.
Similarly, redefining
coordinateshere for both all geometries and multigeometries makes it inferrable. Julia really doesn't seem to like type inference through recursion.