Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow AbstractGPs in WrappedGP #217

Merged
merged 6 commits into from
Dec 26, 2021
Merged

Allow AbstractGPs in WrappedGP #217

merged 6 commits into from
Dec 26, 2021

Conversation

willtebbutt
Copy link
Member

This is a bug fix.

Currently, WrappedGPs only permit GPs to be wrapped, which is limiting.

An unrelated change is the removal of a lot of block-diagonal code that was redundant and broken.

@codecov
Copy link

codecov bot commented Dec 26, 2021

Codecov Report

Merging #217 (270188d) into master (999cd2c) will increase coverage by 3.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #217      +/-   ##
==========================================
+ Coverage   86.42%   89.53%   +3.10%     
==========================================
  Files          17       16       -1     
  Lines         442      344      -98     
==========================================
- Hits          382      308      -74     
+ Misses         60       36      -24     
Impacted Files Coverage Δ
src/gp/gp.jl 100.00% <100.00%> (ø)
src/util/proper_type_piracy.jl 0.00% <0.00%> (-100.00%) ⬇️
src/util/block_arrays/dense.jl 70.58% <0.00%> (-29.42%) ⬇️
src/composite/composite_gp.jl 100.00% <0.00%> (ø)
src/abstract_gp.jl 87.50% <0.00%> (+1.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 999cd2c...270188d. Read the comment docs.

@willtebbutt willtebbutt merged commit c822896 into master Dec 26, 2021
@willtebbutt willtebbutt deleted the wct/abstract-wrap branch December 26, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant