Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return HTTP status 204 for /favicon.ico #146

Closed
wants to merge 14 commits into from

Conversation

Mr-Foo
Copy link

@Mr-Foo Mr-Foo commented Sep 13, 2020

Status 204 (No Content) can be cached by the browser and signifies success.
Without this rule status 404 (Not Found) is returned.

Status 204 (No Content) can be cached by the browser and signifies success.
@Mr-Foo Mr-Foo marked this pull request as ready for review September 13, 2020 17:30
@Joxit Joxit closed this in a15323b Feb 13, 2021
@Joxit
Copy link
Owner

Joxit commented Feb 13, 2021

Hi there, this should be fixed in 1.5.4. I included the icon I use for my website and projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants