Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(getWellKnownSymbolPropertyOfType): test both direct and indirect properties on a type #84

Merged
merged 3 commits into from
Feb 21, 2023

Conversation

RebeccaStevens
Copy link
Collaborator

@RebeccaStevens RebeccaStevens commented Feb 21, 2023

PR Checklist

@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Merging #84 (8f0c5f0) into main (4f34bb5) will increase coverage by 0.46%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
+ Coverage   21.52%   21.99%   +0.46%     
==========================================
  Files          18       18              
  Lines         432      432              
  Branches      172      172              
==========================================
+ Hits           93       95       +2     
+ Misses        316      315       -1     
+ Partials       23       22       -1     
Flag Coverage Δ
4.2.4 21.29% <100.00%> (?)
4.3.5 21.52% <100.00%> (ø)
4.4.4 21.52% <100.00%> (ø)
latest 21.52% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/utils.ts 75.00% <100.00%> (ø)
src/types/getters.ts 36.36% <0.00%> (+6.06%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

src/types/getters.test.ts Outdated Show resolved Hide resolved
@RebeccaStevens RebeccaStevens changed the title test: fix test for ts 4.2 test(getWellKnownSymbolPropertyOfType): test properties both directly and indirectly on a type Feb 21, 2023
@RebeccaStevens RebeccaStevens changed the title test(getWellKnownSymbolPropertyOfType): test properties both directly and indirectly on a type test(getWellKnownSymbolPropertyOfType): test both direct and indirect properties on a type Feb 21, 2023
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@JoshuaKGoldberg JoshuaKGoldberg merged commit 598a1ae into main Feb 21, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the ts4.2-test-fix branch February 21, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests are failing on main
2 participants