Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for ts 4.2 #65

Merged
merged 7 commits into from
Feb 20, 2023
Merged

feat: add support for ts 4.2 #65

merged 7 commits into from
Feb 20, 2023

Conversation

RebeccaStevens
Copy link
Collaborator

@RebeccaStevens RebeccaStevens commented Feb 16, 2023

PR Checklist

Overview

Adds support for old versions of TypeScript, down to 4.2

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #65 (a23c63a) into main (129563e) will decrease coverage by 0.11%.
The diff coverage is 13.04%.

@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
- Coverage   21.63%   21.52%   -0.11%     
==========================================
  Files          17       18       +1     
  Lines         416      432      +16     
  Branches      166      172       +6     
==========================================
+ Hits           90       93       +3     
- Misses        303      316      +13     
  Partials       23       23              
Flag Coverage Δ
4.3.5 21.52% <13.04%> (?)
4.4.4 21.52% <13.04%> (?)
latest 21.52% <13.04%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/nodes/typeGuards/union.ts 1.94% <0.00%> (-0.24%) ⬇️
src/tokens.ts 0.00% <0.00%> (ø)
src/utils.ts 75.00% <75.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I defer to your preference - this is all wonderful either way! Thanks! 🔥

src/nodes/typeGuards/union.ts Show resolved Hide resolved
@RebeccaStevens
Copy link
Collaborator Author

Do we want to temporarily remove testing on typescript@next as the test are failing?

@RebeccaStevens

This comment was marked as outdated.

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what you have now with the isTsVersionAtLeast function referring to ts.versionMajorMinor is probably my favorite approach: no semver dependency; directly asks the typescript package; is clear and understandable.

That being said, at this point I'm happy with whatever approach you want 😄. This package is still pretty new and 0.0.x level. We can always change if we find a need later on. I'd rather experiment in "production" and get it out sooner.

And yeah, a followup issue for typescript@next sounds good to me.

Great stuff either way - let's ship! 🚀 (let me know if you don't have merge permissions, you should)

@RebeccaStevens RebeccaStevens enabled auto-merge (squash) February 19, 2023 07:03
@RebeccaStevens
Copy link
Collaborator Author

@JoshuaKGoldberg I don't have permission to override those required checks that no longer exist.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 4f34bb5 into main Feb 20, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the ts4.2 branch February 20, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: TypeScript 4.2 not supported
2 participants