-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for ts 4.2 #65
Conversation
edd87b8
to
7ce988f
Compare
Codecov Report
@@ Coverage Diff @@
## main #65 +/- ##
==========================================
- Coverage 21.63% 21.52% -0.11%
==========================================
Files 17 18 +1
Lines 416 432 +16
Branches 166 172 +6
==========================================
+ Hits 90 93 +3
- Misses 303 316 +13
Partials 23 23
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
7ce988f
to
d37da96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I defer to your preference - this is all wonderful either way! Thanks! 🔥
Do we want to temporarily remove testing on |
This comment was marked as outdated.
This comment was marked as outdated.
11b3315
to
040d488
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what you have now with the isTsVersionAtLeast
function referring to ts.versionMajorMinor
is probably my favorite approach: no semver
dependency; directly asks the typescript
package; is clear and understandable.
That being said, at this point I'm happy with whatever approach you want 😄. This package is still pretty new and 0.0.x
level. We can always change if we find a need later on. I'd rather experiment in "production" and get it out sooner.
And yeah, a followup issue for typescript@next
sounds good to me.
Great stuff either way - let's ship! 🚀 (let me know if you don't have merge permissions, you should)
@JoshuaKGoldberg I don't have permission to override those required checks that no longer exist. |
PR Checklist
status: accepting prs
Overview
Adds support for old versions of TypeScript, down to 4.2