build: shrink size of bundle

[JoshuaKGoldberg]

PR Checklist

• Addresses an existing open issue: fixes 🐛 Bug: Package size is a whopping 1.2MB #573
• That issue was marked as status: accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

Edit: see later comments.

Turns off the ESBuild bundling that was done with tsup. It was including packages from node_modules/. 😩

Running du -sh lib/:

• Baseline (main): 1.1M
• With this change: 184K

❤️‍🔥

[ArnaudBarre]

I don't have full context, but esbuild have a somewhat recent packages option to make all node modules external without the need to specify them: https://esbuild.github.io/api/#packages

Maybe this can lead to better tradeoff for publishing than disabling completely bundling

[RebeccaStevens]

This change atm is broken. The bundle is tiny because there is no code.

The reason the bundle is so big is because we are shipping source maps. If we remove them, things will be a lot smaller - a saving of about ~700 kB.

The only node dependency being bundled currently is semver - which we shouldn't be doing. I'll fix this up, which will give us another saving.

[JoshuaKGoldberg]

broken

D'oh! Thanks, yes please. I haven't investigated much beyond the initial size check.

source maps

Relevant: typescript-eslint/typescript-eslint#9352. I'm 👍 on removing them.

[RebeccaStevens]

Bundle size is now down to about 360 kB, half of that being types. Also we're releasing both esm and cjs so the actually size of the runtime import is only about 80 kB.

[RebeccaStevens]

@JoshuaKGoldberg should be all good now.

[JoshuaKGoldberg]

Awesome!

[fisker]

Hi, I didn't see this one when I send #587, do you think replace semver with isTsVersionAtLeast is better approach?

[JoshuaKGoldberg]

Hi, I didn't see this one when I send #587, do you think replace semver with isTsVersionAtLeast is better approach?

I like it! Filed #589.

[JoshuaKGoldberg]

Since GitHub still won't let me approve my own PR (sigh), using this in lieu of an approval.

@RebeccaStevens I'm ready to merge all these PRs in together -hopefully including #587?- and get a full 2.0 release if you're happy!