Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use nullish coalescing instead of or operator #39

Merged
merged 1 commit into from
Feb 9, 2023
Merged

refactor: use nullish coalescing instead of or operator #39

merged 1 commit into from
Feb 9, 2023

Conversation

RebeccaStevens
Copy link
Collaborator

PR Checklist

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Feb 9, 2023
View reviewed changes
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, makes sense - ts.getShebang returns string | undefined, so this is a good noop. Cheers!

@JoshuaKGoldberg JoshuaKGoldberg merged commit c68d4bd into JoshuaKGoldberg:main Feb 9, 2023
@RebeccaStevens RebeccaStevens deleted the comments-use-nullish-coalescing branch February 13, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RebeccaStevens @JoshuaKGoldberg