-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: generate types for release #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right! Thanks! 🙌
Codecov Report
@@ Coverage Diff @@
## main #20 +/- ##
=======================================
Coverage 25.31% 25.31%
=======================================
Files 13 13
Lines 237 237
Branches 98 98
=======================================
Hits 60 60
Misses 174 174
Partials 3 3 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, but the package.json
sorting needs to happen. Could you fix the lint issues real quick please?
/home/runner/work/ts-api-tools/ts-api-tools/package.json
Error: 44:4 error Expected object keys to be in ascending order. 'import' should be before 'types' jsonc/sort-keys
Error: 54:2 error Expected object keys to be in ascending order. 'name' should be before 'types' jsonc/sort-keys
One of those linting issue can't be fixed. I don't think sorting |
...huh, TIL (thanks!). I'll admit I haven't set this up before. Do you have a good resource that describes this? |
Have a look at this: https://www.typescriptlang.org/docs/handbook/esm-node.html#packagejson-exports-imports-and-self-referencing |
I guess this is blocked on JoshuaKGoldberg/create-typescript-app#223. 😩 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️🔥
@allcontributors add @RebeccaStevens for bug |
I've put up a pull request to add @RebeccaStevens! 🎉 |
I imagine the reason is because when looking for a matching pattern for the path, |
PR Checklist
status: accepting prs
Overview
Generate types on
build:release
.