-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: default to first declaration for getWellKnownSymbolPropertyOfType properties #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like the look of those casts.
Do we know for sure that those values are always those types?
Codecov Report
@@ Coverage Diff @@
## main #16 +/- ##
==========================================
+ Coverage 19.74% 21.94% +2.19%
==========================================
Files 15 15
Lines 395 401 +6
Branches 161 164 +3
==========================================
+ Hits 78 88 +10
+ Misses 299 291 -8
- Partials 18 22 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
...which I can't do now. The GitHub requests edge cases always confuse me. |
a4664a3
to
51f91bc
Compare
PR Checklist
status: accepting prs
Overview
If
prop.valueDeclaration
doesn't exist, then we assumeprop.getDeclarations()
must have at least one entry (something must have indicated the property exists!)_.I don't know that this assumption is actually 100% correct. But it's at least more correct than how the code was before.