Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sort alphabetically with co-located hooks for scripts #632

Conversation

sasial-dev
Copy link
Contributor

PR Checklist

Overview

Fixes #499 and adds tests 😄

I'm not 100% sold on how I did the implementation, and I'm curious to know your thoughts on it.

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start, sorry for taking so long to get to this! I think you're on the right track - just there's some more edge-case-iness to handle. 🚀

src/rules/sort-collections.ts Show resolved Hide resolved
src/rules/sort-collections.ts Show resolved Hide resolved
@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author Needs an action taken by the original poster label Nov 28, 2024
@github-actions github-actions bot removed the status: waiting for author Needs an action taken by the original poster label Nov 29, 2024
Copy link

codecov bot commented Nov 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.92%. Comparing base (4ea1ae5) to head (25a88b5).
Report is 36 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #632      +/-   ##
==========================================
+ Coverage   98.88%   98.92%   +0.04%     
==========================================
  Files          17       17              
  Lines        1077     1120      +43     
  Branches       98      113      +15     
==========================================
+ Hits         1065     1108      +43     
  Misses         12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sasial-dev
Copy link
Contributor Author

@JoshuaKGoldberg - are you ok if I add postwatch to CSpell? It seems to be triggering it in the tests

@JoshuaKGoldberg
Copy link
Owner

Yup, that seems like the right way to solve that 👍

@sasial-dev
Copy link
Contributor Author

CI should pass now.

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is looking good! I took a deeper look and I think this deserves a bit more unit testing care than most other changes.

src/tests/rules/sort-collections.test.ts Outdated Show resolved Hide resolved
@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author Needs an action taken by the original poster label Nov 30, 2024
@github-actions github-actions bot removed the status: waiting for author Needs an action taken by the original poster label Nov 30, 2024
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Melissa Peterman as Bonnie Wheeler joyfully saying "it's glorious"

@JoshuaKGoldberg JoshuaKGoldberg changed the title feat(sort-collections): sort alphabetically with co-located hooks for scripts feat: sort alphabetically with co-located hooks for scripts Nov 30, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit 4ccae4f into JoshuaKGoldberg:main Nov 30, 2024
17 checks passed
Copy link

🎉 This is included in version v0.17.0 🎉

The release is available on:

Cheers! 📦🚀

@sasial-dev sasial-dev deleted the sort-collections/co-located-hooks branch November 30, 2024 21:51
@sasial-dev
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: sort-collections: alphabetically sorting with co-located hooks for scripts
2 participants