-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sort alphabetically with co-located hooks for scripts
#632
feat: sort alphabetically with co-located hooks for scripts
#632
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start, sorry for taking so long to get to this! I think you're on the right track - just there's some more edge-case-iness to handle. 🚀
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #632 +/- ##
==========================================
+ Coverage 98.88% 98.92% +0.04%
==========================================
Files 17 17
Lines 1077 1120 +43
Branches 98 113 +15
==========================================
+ Hits 1065 1108 +43
Misses 12 12 ☔ View full report in Codecov by Sentry. |
@JoshuaKGoldberg - are you ok if I add |
Yup, that seems like the right way to solve that 👍 |
CI should pass now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is looking good! I took a deeper look and I think this deserves a bit more unit testing care than most other changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scripts
scripts
🎉 This is included in version v0.17.0 🎉 The release is available on: Cheers! 📦🚀 |
Thank you! |
PR Checklist
scripts
#499status: accepting prs
Overview
Fixes #499 and adds tests 😄
I'm not 100% sold on how I did the implementation, and I'm curious to know your thoughts on it.