Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert schedule change for debug render. fixes #496 #497

Merged
merged 2 commits into from
Dec 8, 2024

Conversation

Hellzbellz123
Copy link
Contributor

@Hellzbellz123 Hellzbellz123 commented Aug 23, 2024

opened as draft cause im not sure if a whole new pr/issue is the way to go

revert schedule change for PhysicsDebugPlugin because it causes large lag

Objective

fixes issue #496
recent scheduling changes from commit 4d082a7 causes PhysicsDebugPlugin too generate lots of lag when enabled

Solution

change default schedule from FixedPostUpdate too PostUpdate


revert schedule change for PhysicsDebugPlugin because it causes large lag
@Jondolf Jondolf added A-Debug-Rendering Relates to the debug plugin or any other useful debugging features C-Performance Improvements or questions related to performance labels Dec 8, 2024
@Jondolf Jondolf marked this pull request as ready for review December 8, 2024 15:38
Copy link
Owner

@Jondolf Jondolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this, and performance for the debug rendering / gizmos indeed seems much worse in fixed timestep schedules 🤔 Having it in PostUpdate should be fine though, thanks for the fix!

For Bevy 0.16, we will likely also start using the retained gizmos added in bevyengine/bevy#15473 for collider debug rendering. It should hopefully improve performance significantly.

@Jondolf Jondolf enabled auto-merge (squash) December 8, 2024 15:52
@Jondolf Jondolf merged commit 90478cb into Jondolf:main Dec 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Debug-Rendering Relates to the debug plugin or any other useful debugging features C-Performance Improvements or questions related to performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants