Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix path in children #27

Merged
merged 3 commits into from
Sep 2, 2021
Merged

Conversation

ctholho
Copy link
Contributor

@ctholho ctholho commented May 18, 2021

nested routes may have two different ways to appear on the same route as their parent.

  1. the exact same path (starting with a /)
  2. an empty path

this PR changes the child route to an empty path, whereas before it was the same path. There used to be an error with vite-ssg that has since been fixed. This change would reflect a more explicit way that a page is child to a layout.

This PR also adds a path name to a route in the examples to show that you can still use names.

fixes #26

edit: still WIP

caveat: this creates a warning if you run example:build-ssg:
[Vue Router warn]: No match found for location with path "today"
But today.html page is still generated and works.

@ctholho
Copy link
Contributor Author

ctholho commented May 20, 2021

ready to merge. see comments at #26 if this is necessary.

@JohnCampionJr JohnCampionJr merged commit 839d210 into JohnCampionJr:main Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSG generates useless files
2 participants