dygraph Prim code gen （node.cc) #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiabinYang
reviewed
Jan 3, 2023
| @@ -2328,6 +2354,9 @@ def GenerateNodeDefinition( | |||
| var_str += f"\n{indent} output_str += output_{new_name}_str; " | |||
|
|
|||
| log_str = AFTER_LOG_PRINT_TEMPLATE.format(var_str) | |||
| # TODO Ruting modify in the future | |||
| @@ -1826,16 +1833,19 @@ def GenerateHigherOrderNodeCreationCode(self): | |||
| is_invoke_forward_api = IsInvokeForwardApi( | |||
| self.grad_api_contents, self.forward_apis_dict | |||
| ) | |||
| is_composite_forward_api = False if self.composite_func_info == [] else True | |||
There was a problem hiding this comment.
replace by composite grad api
| next_grad_node_creation_str, | ||
| next_grad_node_out_list, | ||
| next_node_generator.backward_forward_inputs_map, | ||
| ) | ||
| elif not is_invoke_forward_api: | ||
| elif not is_invoke_forward_api and not is_composite_forward_api: |
There was a problem hiding this comment.
if is_invoke_farward_api or is_composite_grad_api next_grad_node_creation_str should be none, we will add this when delete Flags_prim_enabled
add TODO here
| @@ -2225,6 +2241,16 @@ def GenerateNodeDefinition( | |||
| {out_assign_str}}} else {{ | |||
| {indent}{autograd_api_out} api_output = paddle::experimental::{self.namespace}{self.grad_api_contents['invoke']}; | |||
| {out_assign_str}{indent}}} | |||
| """ | |||
| elif is_composite_grad_api: | |||
There was a problem hiding this comment.
Leave TODO here to indicate strategy which will be used later, such as using composite only when we don't have backward kernel
There was a problem hiding this comment.
This should be statically generated here
xiaoguoguo626807
changed the title
JiabinYang
reviewed
Jan 5, 2023
| @@ -2,3 +2,8 @@ cc_library( | |||
| static_utils | |||
| SRCS static_utils.cc | |||
| DEPS proto_desc operator static_global_utils) | |||
|
|
|||
There was a problem hiding this comment.
Avoid this ON INFER and NO PYTHON
JiabinYang
reviewed
Jan 5, 2023
| dygraph_function dygraph_node) | ||
|
|
||
| cc_test_old( | ||
| set(prim_generated_deps final_dygraph_function final_dygraph_node dygraph_function |
| # Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. |
There was a problem hiding this comment.
maybe no need to push these code in this pr?
| @@ -47,8 +47,8 @@ add_custom_target( | |||
| ${forwards_cc_path} | |||
| COMMAND ${CMAKE_COMMAND} -E copy_if_different ${tmp_forwards_h_path} | |||
| ${forwards_h_path} | |||
| # COMMAND ${CMAKE_COMMAND} -E copy_if_different ${tmp_nodes_cc_path} | |||
| # ${nodes_cc_path} | |||
| COMMAND ${CMAKE_COMMAND} -E copy_if_different ${tmp_nodes_cc_path} | |||
There was a problem hiding this comment.
remove additional generated files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types