Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm-shrinkwrap needs to be regenerated or removed #379

Closed
sqal opened this issue Jan 29, 2020 · 1 comment
Closed

npm-shrinkwrap needs to be regenerated or removed #379

sqal opened this issue Jan 29, 2020 · 1 comment

Comments

@sqal
Copy link

sqal commented Jan 29, 2020

Do you want to request a feature, report a bug or ask a question?
Bug

What is the current behavior?
I recently upgraded this plugin from 4.1.6 to the latest version 4.2.0 and all icons in my app have disappeared. After some digging, I found out that it was caused by some old version of svg-baker, reference issue JetBrains/svg-mixer#2. This dependency was updated in the commit 02d0c33 before releasing 4.2.0 but there are still old dependencies listed in npm-shrinkwrap.json.

What is the expected behavior?
npm should install correct dependencies.

Please tell us about your environment:

  • Node.js version: -
  • webpack version: -
  • svg-sprite-loader version: 4.2.0
  • OS type & version: -

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix,

Remove npm-shrinkwrap (not sure why it is needed since the project using yarn lockfile).

kisenka added a commit that referenced this issue Jan 31, 2020
@kisenka
Copy link
Contributor

kisenka commented Jan 31, 2020

Fixed in svg-sprite-loader@4.2.1

@kisenka kisenka closed this as completed Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants