Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate CupertinoScrollDecayAnimationSpec and CupertinoOverscrollEffect #1806

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

ASalavei
Copy link
Collaborator

@ASalavei ASalavei commented Jan 28, 2025

Fixes: https://youtrack.jetbrains.com/issue/CMP-6775/Update-Cupertino-Overscroll-and-Fling-API

Release Notes

Breaking Changes - iOS

  • Experimental classes CupertinoScrollDecayAnimationSpec and CupertinoOverscrollEffect are removed from public API

@ASalavei
Copy link
Collaborator Author

@igordmn , because CupertinoScrollDecayAnimationSpec wasn't mark as ExperimentalFoundationApi, I decided to deprecate both of them instead of making one internal.

Copy link
Member

@MatkovIvan MatkovIvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-word release notes before merging

Like "Removed experimental CupertinoOverscrollEffect and CupertinoScrollDecayAnimationSpec public API, the default behavior of overscroll on iOS is not changed".

Also it shouldn't be in Highlights imho

@ASalavei ASalavei requested a review from MatkovIvan January 29, 2025 09:55
@ASalavei
Copy link
Collaborator Author

ASalavei commented Jan 29, 2025

Also it shouldn't be in Highlights imho

Yep , now we can use Breaking Changes. But before there was no sufficient tile. We have to introduce a new one.

@MatkovIvan
Copy link
Member

Feel free to merge PR. Nitpicking about release notes wording is not a blocker.

For the wording - it sounds too scary imo. I'd explicitly mention that it was experimental APIs (I know one of them formally isn't marked like it) and that the default behaviour of overscroll is not changed

@ASalavei ASalavei merged commit 2544126 into jb-main Jan 29, 2025
7 checks passed
@ASalavei ASalavei deleted the andrei.salavei/deprecate-overscroll-and-fling-api branch January 29, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants