Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report ComposeAccessibleComponents as invisible if their semantics config has SemanticsProperties.HideFromAccessibility #1798

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

m-sasha
Copy link
Member

@m-sasha m-sasha commented Jan 26, 2025

InvisibleToUser is now deprecated in favor of HideFromAccessibility, which we need to support.

Testing

  • Added a unit test

Release Notes

Fixes - Desktop

  • Elements marked with Modifier.semantics { hideFromAccessibility() } should now be correctly hidden from a11y.

…nfig has SemanticsProperties.HideFromAccessibility
@m-sasha m-sasha force-pushed the m-sasha/fix-ComposeAccessibleComponent-isVisible branch from ba852f0 to 30d1abf Compare January 26, 2025 10:59
@m-sasha m-sasha requested a review from igordmn January 26, 2025 11:00
@m-sasha m-sasha merged commit e75bd46 into jb-main Jan 27, 2025
7 checks passed
@m-sasha m-sasha deleted the m-sasha/fix-ComposeAccessibleComponent-isVisible branch January 27, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants