Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing type checks to interop container listener #1747

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

MatkovIvan
Copy link
Member

java.lang.IllegalArgumentException: Required value was null.
	at androidx.compose.ui.viewinterop.SwingInteropContainer.getClipRectForComponent(SwingInteropContainer.desktop.kt:247)
	at androidx.compose.ui.scene.ComposeSceneMediator$containerListener$1.addClipComponent(ComposeSceneMediator.desktop.kt:200)
	at androidx.compose.ui.scene.ComposeSceneMediator$containerListener$1.componentAdded(ComposeSceneMediator.desktop.kt:189)
	...
	at java.desktop/java.awt.Container.add(Container.java:1033)
	at androidx.compose.ui.scene.SwingComposeSceneLayer.<init>(SwingComposeSceneLayer.desktop.kt:122)
	at androidx.compose.ui.scene.ComposeContainer.createPlatformLayer(ComposeContainer.desktop.kt:396)

Release Notes

Fixes - Desktop

  • Fix possible exception during Dialog/Popup creation in case of compose.layers.type=COMPONENT and pointing windowContainer to ComposePanel itself

@MatkovIvan MatkovIvan requested a review from igordmn December 18, 2024 15:08
@MatkovIvan MatkovIvan merged commit 9e8a20f into jb-main Dec 18, 2024
7 checks passed
@MatkovIvan MatkovIvan deleted the ivan.matkov/fix-layers-and-interop-mix branch December 18, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants