Remove MainTestClockImpl.onTimeAdvanced #1618
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have a rendering loop in tests, it's no longer necessary to call
render
every time the test clock is advanced. In fact, it is incorrect to do so. The following test succeeds on Android, but fails on the desktop:Following that, our changes to
AbstractMainTestClock
are no longer needed, and Upstreaming. commonization. ui-test. AbstractMainTestClock is also no longer needed.Fixes https://youtrack.jetbrains.com/issue/CMP-5776/Upstreaming.-commonization.-ui-test.-AbstractMainTestClock
Testing
Added a new unit test.
Release Notes
Breaking Changes - Multiple Platforms
mainClock
such that it doesn't reach the next frame, will no longer cause a recomposition.