Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fling animation for fast scrolling gestures #1616

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

ASalavei
Copy link
Collaborator

@ASalavei ASalavei commented Oct 3, 2024

Fixes: https://youtrack.jetbrains.com/issue/CMP-6791

Testing

Release Notes

Fixes - iOS

  • Fling animation works correctly for fast scrolling gestures

Copy link
Member

@MatkovIvan MatkovIvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer changing this common part in AOSP first

@ASalavei
Copy link
Collaborator Author

ASalavei commented Oct 14, 2024

I'd prefer changing this common part in AOSP first

As far as I know, the initial part hasn't been upstreamed yet. I think this type of changes are valid for now.
Here is the ticket to upstream changes: https://youtrack.jetbrains.com/issue/CMP-6853/Upstream-VelocityTracker1D-changes-to-AOSP

@ASalavei ASalavei requested a review from MatkovIvan October 14, 2024 12:14
@ASalavei ASalavei merged commit a663b6f into jb-main Oct 15, 2024
6 checks passed
@ASalavei ASalavei deleted the andrei.salavei/fix-fling-for-fast-gestures branch October 15, 2024 10:49
ASalavei added a commit that referenced this pull request Oct 22, 2024
Fixes: https://youtrack.jetbrains.com/issue/CMP-6791

## Testing
- Check fast gesture for fling (see the issue description)
- Ensure that unintentional fling is not reproduced after the stop and
lift up gesture:
JetBrains/compose-multiplatform#3335

## Release Notes
### Fixes - iOS
- Fling animation works correctly for fast scrolling gestures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants