Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored mainMenu and fetching categories to use 1 call #14

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Refactored mainMenu and fetching categories to use 1 call #14

merged 1 commit into from
Jan 9, 2023

Conversation

Kara-Zor-El
Copy link
Member

  • this is done because the 2 simultaneous calls to the server might cause issues
  • I refactored the delete non-existent entries portion since it could have been improved and that could also be the case
  • Tested and this does in fact fix it
  • I think a better solution in the future may be to use a stream to only update content and delete when necessary then it could be changed live without a refresh constantly

@Kara-Zor-El
Refactored mainMenu and fetching categories to use 1 call
b46a255 
- this is done because i think the 2 simultaneous calls to the server might cause issues
- I refactored the delete non-existent entries portion since it could have been improved and that could also be the case
- The issue seems to only happen in iOS so im committing to test on iOS first
@Kara-Zor-El Kara-Zor-El linked an issue Jan 9, 2023 that may be closed by this pull request
Collections Disappearing #12
Closed
@Kara-Zor-El Kara-Zor-El merged commit 5a9de04 into main Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collections Disappearing
1 participant
@Kara-Zor-El