Fix parsing of some modern ICNS files #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TOC is variable length Icons that are not recognised should be skipped as well Fixes rendering of Apple Mail and other modern icons
JackMordaunt
requested changes
Apr 13, 2020
JackMordaunt
approved these changes
Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the parser to skip whole chunks of uninteresting data so we do not stumble over false-positive matches.
Primarily this is skipping the whole table of contents so it does not accidentally find empty images.
Additionally it skips resources that we don't recognise such as unsupported image data etc.
To test see the Apple Mail icon in Catalina