Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync lang fix #5415

Merged
merged 19 commits into from
Oct 9, 2019
Merged

Sync lang fix #5415

merged 19 commits into from
Oct 9, 2019

Conversation

koppor
Copy link
Member

@koppor koppor commented Oct 9, 2019

Fixes #3573.

Stefan added 19 commits February 18, 2018 04:48
Fixed unicode string
ea5d56e
Fixed logical issue within merging process
ba7d87d
Added format_key_and_value method
254449f
Added new line for new properties
b00bfdd
Renamed method and moved Path variables into PathFinder class
7a7f33f
Removed empty line, except statement is now catching ImportErrors
759ea5d
Ignoring empty keys again, new keys are added in english by default.
f575245
Removed debug messages
19edb0f
Had to kick out the Path variables of the class again. :/
011501d
Improved method names
e864d2c
Reworked command-line interface
d940de0
Reworked logging functionality, added new command-line options
c5eecef
small fix on ´getJabRefBaseDirectory´ method
35b7f83
forgot brackets...
ded149b
Removed ´getScriptLocation´ method
1379dad
Added ´BASE_DIRECTORY_NAME´ variable to PathFinder class
e7be7ef
Print commands will now use localization directory by default
cb21464
Missing keys will no longer be written to the properties files
fb3bba0
Fixed missing key issue
432a92b
@koppor koppor merged commit ccfa991 into JabRef:master Oct 9, 2019
@koppor
Copy link
Member Author

koppor commented Oct 9, 2019

I found #3573 and saw that @Brainsucker92 worked on it, fixed it, but did not create a pull request. So, I just did it.

@Brainsucker92 Thank you for your work! You are very welcome to join #hacktoberfest.

@Siedlerchr
Copy link
Member

With Crowdin the script should be obsolete as crowdin automatically handles this.

@koppor
Copy link
Member Author

koppor commented Oct 9, 2019 •
edited
Loading

Sorry, I did not link my comment, why I still need this:

#3573 (comment)

An admin might still need it. Quoting: #3635 (comment)

That task won't be necessary for all contributors, only for maintainers wanting to cleanup the files (like sorting, ...). However, this is not absolutely necessary anymore since Crowdin basically takes care.

@Brainsucker92
Copy link
Contributor

Actually I think all these commits shown above were merged already with this pull request: #3743
But I'm still glad I could help you guys!

@Brainsucker92 Brainsucker92 deleted the syncLang_fix branch October 10, 2019 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gradle task localizationUpdate does not work
3 participants
@koppor @Siedlerchr @Brainsucker92