Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return token width #395

Merged
merged 1 commit into from
Dec 28, 2022
Merged

Fix return token width #395

merged 1 commit into from
Dec 28, 2022

Conversation

JSAbrahams
Copy link
Owner

Summary

Noticed that the error messages looked weird.
Turns out return token is 6 wide not 5.

Added Tests

  • Modified test where we pare return

Noticed that the error messages looked weird.
Turns out return token is 6 wide not 5.
@JSAbrahams JSAbrahams added the bug: parse Something in the parse module isn't working (as intended) label Dec 28, 2022
@JSAbrahams JSAbrahams added this to the v0.3.5 | Error handling milestone Dec 28, 2022
@JSAbrahams JSAbrahams self-assigned this Dec 28, 2022
@codecov
Copy link

codecov bot commented Dec 28, 2022

Codecov Report

❗ No coverage uploaded for pull request base (v-0-3-5@986ffda). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             v-0-3-5     #395   +/-   ##
==========================================
  Coverage           ?   87.40%           
==========================================
  Files              ?      109           
  Lines              ?    12040           
  Branches           ?        0           
==========================================
  Hits               ?    10523           
  Misses             ?     1517           
  Partials           ?        0           

@JSAbrahams JSAbrahams merged commit fdb95f4 into v-0-3-5 Dec 28, 2022
@JSAbrahams JSAbrahams deleted the fix-return-token-width branch December 28, 2022 11:48
JSAbrahams added a commit that referenced this pull request Dec 28, 2022
Noticed that the error messages looked weird.
Turns out return token is 6 wide not 5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: parse Something in the parse module isn't working (as intended)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant